I am not (even close) to an expert on SHA hash functions, but after looking at the Perlshop code, I wouldn't trust that code for production use. It also appears not to have been updated since '98 (use CGI or die;).

I would use Digest::SHA1

use strict;
use warnings;

use Digest::SHA1  qw(sha1_hex);

my $data = "squeamish ossifrage\n";
print sha1_hex($data);
[download]

If you are actually using Perlshop and can't switch quickly, refactor the SHA sub to use Digest::SHA1 then look at switching to Interchange which is actively developed.

For anyone who's interested here is the SHA sub in question (formatting intact):

&SHA("squeamish ossifrage\n");
# vs.
&SHA('squeamish ossifrage\n');
[download]

That's only because the character strings themselvers are different. The string "squeamish ossifrage\n" ends with a newline character, while 'squeamish ossifrage\n' ends with a backslash followed by a letter n. The \n sequence isn't special within single quotes.

Well that was the point I was trying to make. How is "\n" interpolated if he was on a windows server? Does it interpolate to '\r\\n' ?

---

I'm not really a human, but I play one on earth. Cogito ergo sum a bum

Thanks to all! It's working good now.

I found an evolved version of my SHA subroutine at: http://mail-archives.apache.org/mod_mbox/spamassassin-commits/200407.mbox/%3C20040701190945.25657.qmail@minotaur.apache.org%3E This one will also use Digest::SHA1 optionally if I read correctly, with 40X higher speed (!?).

I played around with Perlshop 3.2 in the late nineties, customizing it for selling aerial photos searchable on maps, or in tables. This museum piece sleeps at: http://afoto.com/hildebilde/index.htm

Had a lot of fun making it bilingual.

Development of Perlshop continues at a good clip in version 4, with some nice features added while remaining effable for a neophyte like myself. This is the one that gave me the SHA error initially, but seems stable with the alternative routine.

It would be interesting to compare the speed with, and without Digest::SHA1 under load.

Thanks again for pointing me in the right direction!

Dagfinn

Could someone explain to me exactly what to change in perlshop.cgi to get the above to work please. Thank you