Beefy Boxes and Bandwidth Generously Provided by pair Networks
go ahead... be a heretic
 
PerlMonks  

Re: RFC: CGI::Application::Plugin::REST

by stvn (Monsignor)
on Dec 21, 2006 at 14:43 UTC ( #591114=note: print w/ replies, xml ) Need Help??


in reply to RFC: CGI::Application::Plugin::REST

After a quick skim, it looks pretty good to me, one comment on the SYNOPSIS though.

sub get_widget { my ($self, $params) = @_; unless (my_validation_function($params->{product_number})) { REST_error('404', 'Invalid product_number'); } my $widget = $widgets[$params->{product_number}]; if (REST_media_type eq 'text/plain') { return $self->plain_output($widget); } return $self->fancy_output($widget); }
Shouldn't the calls to REST_error and REST_media_type be method calls, and not function calls?

Also, I would suggest wrapping $params in an object as well. You might not need it now, but when you do, it will be a royal pain to go back and change all the legacy code. (give Class::Param a look, it seems to have lots of functionality available if/when you need it)

-stvn


Comment on Re: RFC: CGI::Application::Plugin::REST
Select or Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://591114]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others having an uproarious good time at the Monastery: (6)
As of 2015-07-05 13:45 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









    Results (67 votes), past polls