Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister

Re: RFC: CGI::Application::Plugin::REST

by stvn (Monsignor)
on Dec 21, 2006 at 14:43 UTC ( #591114=note: print w/replies, xml ) Need Help??

in reply to RFC: CGI::Application::Plugin::REST

After a quick skim, it looks pretty good to me, one comment on the SYNOPSIS though.

sub get_widget { my ($self, $params) = @_; unless (my_validation_function($params->{product_number})) { REST_error('404', 'Invalid product_number'); } my $widget = $widgets[$params->{product_number}]; if (REST_media_type eq 'text/plain') { return $self->plain_output($widget); } return $self->fancy_output($widget); }
Shouldn't the calls to REST_error and REST_media_type be method calls, and not function calls?

Also, I would suggest wrapping $params in an object as well. You might not need it now, but when you do, it will be a royal pain to go back and change all the legacy code. (give Class::Param a look, it seems to have lots of functionality available if/when you need it)


Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://591114]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others lurking in the Monastery: (13)
As of 2016-10-28 16:24 GMT
Find Nodes?
    Voting Booth?
    How many different varieties (color, size, etc) of socks do you have in your sock drawer?

    Results (386 votes). Check out past polls.