Re: push/append to hash in a loop

[agianni]

Consider using fetchrow_hashref instead of fetchrow_arrayref:

while ( my $row = $sth->fetchrown_hashref ){
  $hasho{ $row{org_id} } = $row{org_nm};
}

If you really need to use fetchrow_array for some reason, you can just dump the results directly into variables:

while ( my ( $org_id, $org_nm ) = $sth->fetchrow_array()) {
  $hasho{$org_id} = $org_nm;
}

Or, if you want to get real Perl-ish:

my %hash = map { $_->{org_id} => $_->{org_nm} } @{ $sth->fetchall_arra
+yref };

Also, no need for the quoting of variables on the last line of your code.

[grinder]

If you really need to use fetchrow_array for some reason

A good reason is that it's faster (update: erm: fetchrow_arrayref I mean. fetchrow_array is a fetch with training wheels). In my experience, if I want to do something hashy with the results of a DB fetch, it's usually faster to do exactly what I want in a loop over fetchrow_arrayref, rather than fetchrow_hashref.

That is, you don't always need the entire row stored as key/value pairs. Usually all you need are a couple of key/value pairs (that usually correspond to a unique index tuple) and the rest of the values you can store in a list.

And that list of values winds up being formatted in a simple join or join( '...', map). The cost of uselessly hashifying these values is what hurts.