|
|
| P is for Practical | |
| PerlMonks |
Re: Someone please verify this.by Zaxo (Archbishop) |
| on Jul 10, 2007 at 03:58 UTC ( #625758=note: print w/ replies, xml ) | Need Help?? |
|
Your C-style for loop runs from zero to minus one, because $#efile refers to the last index of the array @efile, which is created on the spot - empty. Your task will be much simpler if it is written using the idiomatic $_ variable. That has the benefit that the file is read and processed one line at a time, with no space taken for an array to hold it. I added warnings and strict, which would have told you what was wrong. I also improved open to the 3-arg form and added error checking in case open fails. I don't believe your character class is exactly what you think it is because of all the commas and escapes. I didn't modify the s/// statement because I didn't know its intent. After Compline,
In Section
Seekers of Perl Wisdom
|
|
||||||||||||||||||||