Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister
 
PerlMonks  

Re: XSS-Bug in HTML::BBCode

by moritz (Cardinal)
on Aug 14, 2007 at 13:39 UTC ( #632487=note: print w/ replies, xml ) Need Help??


in reply to XSS-Bug in HTML::BBCode

This looks like a (severe) bug indeed. Did you notify the author of HTML::BBCode?

(Update: fixed link)


Comment on Re: XSS-Bug in HTML::BBCode
Re^2: XSS-Bug in HTML::BBCode
by Taulmarill (Deacon) on Aug 14, 2007 at 13:43 UTC
    Just posted a bug report on http://rt.cpan.org
    It took me a while to find my password for PAUSE, cause i use it rarely.

      Thanks for reporting!

      I'll see if I can patch it asap. Any pointers on how to prevent this in a nice way could be helpful :-)

      --
      b10m

      All code is usually tested, but rarely trusted.

        I guess that allowing only /^\w+$/ as values is a sane approach at least for the [color] tag. For the other values, you will need to come up with other ways, I suggest restrictive regular expressions there as well. As long as you keep the permissions restrictive in the sense that your REs describe what's allowed instead of describing what's forbidden, you'll be safe(r).

        Especially for the [colour] tag, you could also explicitly list the set of allowed colours in your regular expression.

        Lucky for you i had some time to read your source ;-)

        I think the main-problem is how $attr is handled in sub _do_BB. Basically you should try to filter any content in $attr which is not what you expect. Right now you filter < and >. In addition you should also filter ; and " since ; can begin a new css-attribute and " can end the css altogether and start something new (like i did with onmouseover="").

        Maybe it would also be nice to change the behavior from just filtering out all unwanted stuff to changing broken BBCode into text. That would resemble what phpBB actually does.
        You might consider using HTML::StripScripts (I'm the maintainer) as a filter for your output HTML. It'll filter tags, attributes and styles. Instead of returning the HTML directly, you would need to feed it tokens like start and end tags with attributes, content etc, and set the level of filtering that you would like.

        Have a look at HTML::StripScripts::Parser and HTML::StripScripts::LibXML for ideas of how to interface with HTML::Stripscripts.

        Clint

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://632487]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others cooling their heels in the Monastery: (11)
As of 2014-07-23 06:21 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    My favorite superfluous repetitious redundant duplicative phrase is:









    Results (133 votes), past polls