Beefy Boxes and Bandwidth Generously Provided by pair Networks
Pathologically Eclectic Rubbish Lister

Re^2: XSS-Bug in HTML::BBCode

by Taulmarill (Deacon)
on Aug 14, 2007 at 14:11 UTC ( #632501=note: print w/ replies, xml ) Need Help??

in reply to Re: XSS-Bug in HTML::BBCode
in thread XSS-Bug in HTML::BBCode

Lucky for you i had some time to read your source ;-)

I think the main-problem is how $attr is handled in sub _do_BB. Basically you should try to filter any content in $attr which is not what you expect. Right now you filter < and >. In addition you should also filter ; and " since ; can begin a new css-attribute and " can end the css altogether and start something new (like i did with onmouseover="").

Maybe it would also be nice to change the behavior from just filtering out all unwanted stuff to changing broken BBCode into text. That would resemble what phpBB actually does.

Comment on Re^2: XSS-Bug in HTML::BBCode

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://632501]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others perusing the Monastery: (15)
As of 2015-11-24 23:53 GMT
Find Nodes?
    Voting Booth?

    What would be the most significant thing to happen if a rope (or wire) tied the Earth and the Moon together?

    Results (666 votes), past polls