Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl Monk, Perl Meditation
 
PerlMonks  

Re: Extracting an array from a module

by GrandFather (Cardinal)
on Oct 13, 2007 at 23:32 UTC ( #644691=note: print w/ replies, xml ) Need Help??


in reply to Extracting an array from a module

What is it that actually bothers you with the first sub? The   return \@gencli; is about the cheapest way there is of returning an array from a sub - which one way or another is what you are doing.

I would be much more worried about the potential confusion in the mind of a reader of the code caused by overloading gencli three ways - as a sub name, a scalar containing a file name, and as an array.

Note too that using & to call a sub is generally frowned on except in a few rare special situations where the calling sub's argument list (@_) is to be passed into the called sub or you wish to ignore a sub's prototype.

The two lines:

my $gencli_scalar = gencli(); my @gencli = @{ $gencli_scalar };

might be better rewritten:

my @gencli = @{gencli()};

(although I'd use a different identifier for the array). However, generally there is probably no need to actually copy the array at all, but simply dereference the array reference returned by the sub as required.


Perl is environmentally friendly - it saves trees


Comment on Re: Extracting an array from a module
Select or Download Code
Re^2: Extracting an array from a module
by jonnyfolk (Vicar) on Oct 14, 2007 at 06:59 UTC
    Au contraire, I was pretty happy with the first sub, it was the way I was extracting the information that I was uncertain about (rightly). Your explanations are spot on and you have shown me the 'better way' that I was looking for. Thank you.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://644691]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others perusing the Monastery: (7)
As of 2014-10-20 04:43 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    For retirement, I am banking on:










    Results (72 votes), past polls