Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl: the Markov chain saw

Re: problem with a regex loop

by grep (Monsignor)
on Oct 30, 2007 at 21:26 UTC ( #648118=note: print w/replies, xml ) Need Help??

in reply to problem with a regex loop

This is one big reason to indent.

If you had indented and put in some whitespace you would see:

for my $line (@lines){ if( $Session->{'usrSystem'} )=~/$line/g; $Response->Write("Found a match! Hooray"); }
Right there I can look at that code and see that the if isn't closed. And I notice that the if is missing an opening curly {.

If I just look at (instead of read) this code I can instantly tell the blocks look balanced

foreach my $line (@lines) { if ( $Session->{'usrSystem'} =~ /$line/g ) { $Response->Write("Found a match! Hooray"); } }

One dead unjugged rabbit fish later...

Replies are listed 'Best First'.
Re^2: problem with a regex loop
by grashoper (Monk) on Oct 30, 2007 at 21:53 UTC
    your right, I will definitely try to indent more often, and thanks for the help, I am getting closer to my goal which is to make this a switch for the main app, due to upgrades content needs to change on a rolling upgrade schedule.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://648118]
[SuicideJunkie]: email tests, eh? I've gotten dinged for "you can't block this sender as spam, they're internal"
[Corion]: Heh - somebody in our marketing departement thought it was a great idea to use the alerting tool for company-wide outages to announce some new feature ;)

How do I use this? | Other CB clients
Other Users?
Others studying the Monastery: (12)
As of 2017-05-24 14:40 GMT
Find Nodes?
    Voting Booth?