Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl Monk, Perl Meditation
 
PerlMonks  

Re^2: Eliminating conditional code for GUI and text-mode operation

by gnosti (Friar)
on Dec 08, 2007 at 09:09 UTC ( #655812=note: print w/replies, xml ) Need Help??


in reply to Re: Eliminating conditional code for GUI and text-mode operation
in thread Eliminating conditional code for GUI and text-mode operation

I'm thrilled to begin getting this... although some hours are going by...

As stand-alone code, this example produces the expected output. As a module (built with the h2xs boilerplate) make test fails with:

Tried to use 'TestOO'. # Error: Can't locate object method "new" via package "UI::Graphical" at /media/jroth/ecmd-dev/TestOO/blib/lib/TestOO.pm line 56.

Any ideas about this? I just pasted this stuff into the 'precompiled methods go here' indicator in the boilerplate.

Is there a reason why the children would inherit 'new' from the superclass in one context and not in another?

package UI; use Object::Tiny qw(dummy); sub hello {print "superclass hello\n"}; package UI::Graphical; @ISA = 'UI'; sub hello {print "make a window\n";} my $ui = UI->new; $ui->hello; $ui = UI::Graphical->new; $ui->hello; 1;
  • Comment on Re^2: Eliminating conditional code for GUI and text-mode operation
  • Download Code

Replies are listed 'Best First'.
Re^3: Eliminating conditional code for GUI and text-mode operation
by ikegami (Pope) on Dec 08, 2007 at 14:06 UTC
    Are you sure that's the code you ran? It should work. And it works for me.
    >perl 655812.pl superclass hello make a window

    use Object::Tiny qw(dummy);
    can be written as
    use Object::Tiny;
    but not as
    use Object::Tiny qw( ); or
    use Object::Tiny ( );
    You would get the error you showed if you did one of the latter two.

    Also, if you have no members, you can use
    $ui = 'UI'; instead of $ui = UI->new();, and
    $ui = 'UI::Graphical'; instead of $ui = UI::Graphical->new();.
    However, you'll probably need some members, so you might as well continue the way you are going.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://655812]
help
Chatterbox?
[choroba]: The problem was bigger, as the test tried to call a method that didn't exist anymore
[marinersk]: :: ducking ::
[choroba]: because, someone renamed the method, but didn't notice it was used in the test, as the test was skipped
[marinersk]: Well, if the method doesn't exist, it would be hard to pass the test.
[choroba]: later, someone removed the new method, as all its usage places were safe, but didn't notice the test still used the old name
[choroba]: fortunately, it wasn't that hard to replace the method and fix a few remaining failures due to the changes we did to the codebase over the years
[marinersk]: choroba Sounds like a process improvement opportunity; tests may not all need to be run, but they should all be compiled with perl -c before check-in/promotion happens.
[choroba]: so, now I have the test, so I can start making changes in the code. Back to the original ticket, yay!
[marinersk]: I definitely love it when my $current_taask=& taskPop(); if ($current_task eq $original_task) { } is true.
[marinersk]: s/taask/task/g;

How do I use this? | Other CB clients
Other Users?
Others studying the Monastery: (14)
As of 2017-05-25 15:14 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?