Sendmail problem

[himajin]

Hi, I'm having trouble getting the right "From: " in emails sent using sendmail. If I define my $sender as an email address, it works fine, but when I try to read the email in as a parameter from a form, when the mail is delivered, it appears as: "[e-mail]"@myservername How can I stop it from putting it in quotes and attaching the server name? (I'm not sure if the problem is coming from the sendmail part or the parameter reading part, so I put in both). Parameter reading:

use CGI qw(:standard);
@paramater=param();
$numberofparamaters=@paramater;
$i=0;
while ($i<$numberofparamaters)
{
@data[$i] = param(@paramater[$i]);
if (@paramater[$i] =~ /email/)
    {
    $sender=@data[$i];
    }
$i++;
}
$sender =~ s/@/\\@/;

Sendmail:

my ($to, $from, $subject, $message) = @_;
my $sendmail = '/usr/sbin/sendmail';
open(MAIL, "|$sendmail");
print MAIL "From: $sender\n";
print MAIL "To: ???\@gmail.com\n";
print MAIL "Subject: Amapro signup\n\n";
$i=0;
while ($i<$numberofparamaters)
    {
    print MAIL "@paramater[$i]";
    print MAIL ": ";
    @data[$i] = param(@paramater[$i]);
    print MAIL @data[$i];
    print MAIL "\n";
    $i++;
    }
close(MAIL);

[pc88mxer]

To elaborate on the above response, I think the culprit is:

$sender =~ s/@/\\@/;

(Note that the s/@/\@/ in the above response do not actually change anything.) In general there shouldn't be any need to escape at-signs in your email addresses. If you do, sendmail will add @yourdomain.com to fully qualify the address.

In this line:

print MAIL "To: ???\@gmail.com\n";

you need to escape the @ only because it is in a double-quoted string and you don't want it to be interpreted as array interpolation. If you used a single-quoted string you wouldn't need the backslash. However, in previous line:

print MAIL "From: $sender\n";

there is no need to escape any at-signs in $sender - its value will be inserted without any further interpretation.

[Anonymous Monk]

Thanks so much! I really appreciate your help because I spent hours on this yesterday. It works great now.

[doc_faustroll]

The below works just fine:

 #assuming email_address was declared and currently has no escapes
 #print "from is $from_string\n";
    $email_address =~ s/@/\@/;
    $from_string   =~ s/@/\@/;

    open( SENDMAIL, "|/usr/lib/sendmail -oi -t" )
        or die "Can't fork for sendmail: $!\n";
    print SENDMAIL <<"EOF";
From: $from_string
To: $email_address
Subject: $subject
Content-type: text/html
$$textref
EOF
    close(SENDMAIL) or warn "sendmail didn't close nicely";
    print qq ( email sent to $email_address\n);