Beefy Boxes and Bandwidth Generously Provided by pair Networks
Just another Perl shrine

Re^4: Strategy for conditional logging in tests

by andreas1234567 (Vicar)
on Apr 02, 2008 at 05:28 UTC ( #677893=note: print w/replies, xml ) Need Help??

in reply to Re^3: Strategy for conditional logging in tests
in thread Strategy for conditional logging in tests

Well, I could always add functionality to toggle logging on or off and invoke it during tests, e.g. something simple like this:
sub log_toggle { ($_[0]) ? Log::Log4perl->appender_thresholds_adjust(7) : Log::Log4perl->appender_thresholds_adjust(-7); }
However I think it's inelegant to add functionality to the script that is going to be used during testing only. I would rather that the test script did that alone.

Replies are listed 'Best First'.
Re^5: Strategy for conditional logging in tests
by Thilosophy (Curate) on Apr 02, 2008 at 08:42 UTC
    Maybe there is something I do not understand about Log4Perl, but could you not call Log::Log4perl->appender_thresholds_adjust from within your test script? The whole point of a configurable logging framework seems to be that you can configure logging from outside of the code that does the actual logging.
      Brilliant, I never thought of that. It works:
      # foo.t use strict; use warnings; use Test::More qw/no_plan/; use Test::Exception; require_ok(q{}); Log::Log4perl->appender_thresholds_adjust(7); # disable logging # ------ negative tests for add() ------ throws_ok { add(); } qr/error/i, q{Expect error when no args}; ... Log::Log4perl->appender_thresholds_adjust(-7); # enable logging # ------ positive tests for add() ------ cmp_ok(add(2,2), q{==}, 4, q{Expect 2+2=4}); # Note: I want a warning here: cmp_ok(add(1000,1000), q{==}, 2000, q{Expect 1000+1000=2000}); __END__
      This gives me the warning I wanted:
      $ prove foo.t foo......1/? [WARN] 2008/04/02 11:26:41 main::add - possible + overflow foo......ok All tests successful. Files=1, Tests=8, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.08 cusr + 0.01 csys = 0.10 CPU) Result: PASS
      Thanks Thilosophy!

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://677893]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others studying the Monastery: (7)
As of 2017-09-25 19:56 GMT
Find Nodes?
    Voting Booth?
    During the recent solar eclipse, I:

    Results (288 votes). Check out past polls.