Beefy Boxes and Bandwidth Generously Provided by pair Networks
We don't bite newbies here... much

Re: Perl::Critic and file types

by rir (Vicar)
on Mar 02, 2009 at 15:21 UTC ( #747481=note: print w/replies, xml ) Need Help??

in reply to Perl::Critic and file types

If I felt as you do, I'd probably add a perlcritic check to my makes. But you could just use themes something like this:
#!/usr/bin/perl use warnings; use strict; use File::Basename; my ( $DEFAULT, $PM_THEME, $PL_THEME, $T_THEME ) = qw( rir rir_large rir rir ); my %themes = ( '.t' => $T_THEME, '.pm' => $PM_THEME, '.pl' => $PL_THEME, ); my $file = pop @ARGV; my ( $name, $path, $suffix ) = fileparse( $file, qr{\.\w+} ); local $, = ' '; # forking could scale up better if ($suffix) { print `perlcritic @ARGV -theme $themes{$suffix} $file`; } else { # STDIN or unknown extension ( or anything else YYY? ) print `perlcritic @ARGV -theme $DEFAULT $file`; }
Be well,

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://747481]
[Eily]: you could tie a variable into not having the same value each time, if you like to make people who try to debug your code facepalm
[Corion]: perl -wle 'package o; use overload q("") => sub {warn "str"; ""}, bool => sub{warn "bool"; 1}; package main; my $o={}; bless $o => o; print "Yay" if ($o && !length($o))'
[Corion]: But people writing such code should document the objects they construct and why it makes sense for an object to be invisible as string while being true in a boolean context
[hippo]: That's equal parts clever and horrendous.
[Eily]: the overload version wouldn't return true with "$x" && !length $x though, I guess
[hippo]: The more I look at this code, the more $x is a plain old scalar and the more this condition will never be true. I'm calling it a bug at this point.
[hippo]: Thanks for your input which has soothed my sanity (a little)
[Corion]: Eily: Sure - if you force both things into stringy things, then you break that magic. But that would also mean that you changed the expression, as now $x = 0.00 will be true instead of false as it were before
[Corion]: Ah no, at least in my feeble experiments that doesn't change the meaning
[Corion]: We sell sanity in small packages ;)

How do I use this? | Other CB clients
Other Users?
Others contemplating the Monastery: (8)
As of 2017-07-27 13:42 GMT
Find Nodes?
    Voting Booth?
    I came, I saw, I ...

    Results (413 votes). Check out past polls.