Beefy Boxes and Bandwidth Generously Provided by pair Networks
Don't ask to ask, just ask

Re: how to improve my script

by betterworld (Curate)
on Jun 15, 2009 at 13:27 UTC ( #771655=note: print w/replies, xml ) Need Help??

in reply to how to improve my script

From looking at your code, it appears that it is vulnerable to directory traversal attacks. If someone requests URLs like "/../../../../../../etc/passwd", you happily deliver the system's user database.

Also I'd guess that you'll get a lot of warnings if a client terminates the connection without sending a request.

However I may be wrong; I did not run your code, I only had a look at it.

I realize that you are doing this only as an exercise, but I'd strongly recommend thinking about malicious input when writing networking software.

Replies are listed 'Best First'.
Re^2: how to improve my script
by afoken (Monsignor) on Jun 15, 2009 at 17:59 UTC

    I'm missing taint mode and any kind of input validation. I see code written in Perl4 style (&log(...)), I see repeated (hidden) stat calls (-e $DOCROOT.$uri, then -d $DOCROOT.$uri, then -f $DOCROOT.$uri), I see open where stat is sufficient (# open $f to get its modification time). And I'm sure perlcritic would find a lot more than this.


    Today I will gladly share my knowledge and experience, for there are no sweeter words than "I told you so". ;-)

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://771655]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others meditating upon the Monastery: (8)
As of 2016-10-24 08:08 GMT
Find Nodes?
    Voting Booth?
    How many different varieties (color, size, etc) of socks do you have in your sock drawer?

    Results (303 votes). Check out past polls.