Beefy Boxes and Bandwidth Generously Provided by pair Networks
Syntactic Confectionery Delight
 
PerlMonks  

Re^2: RFC: Module - GSM::Nbit

by techcode (Hermit)
on May 14, 2010 at 06:05 UTC ( #839943=note: print w/ replies, xml ) Need Help??


in reply to Re: RFC: Module - GSM::Nbit
in thread RFC: Module - GSM::Nbit

Yeah - there are some typos as I still need to run it through a spell checker (and perlcritic) - any tools for that?

EDIT: perlcritic does a nice job of spell checking as well :)

I had the code indented, but then in man pages it looked like double indented from being inside a section + code indentation itself. But I agree it looks better that way so reverting + removing spaces between variable, = and value.

Yes for more data validation - I also "unified" so everything just does "return unless xyz;" instead of having both that and "return '' unless xyz;" in a few places.

Agree on examples directory :)

As of world writable files - that would be a bugger to figure out on my own. But looking at my folder structure I have standard chmod 644 for files and 755 for folders. So I'm not sure what's wrong?

First point I don't completely agree on - I believe INSTALLATION section is there for the CPAN web page?

Thanks!


Have you tried freelancing/outsourcing? Check out Scriptlance - I work there since 2003. For more info about Scriptlance and freelancing in general check out my home node.


Comment on Re^2: RFC: Module - GSM::Nbit
Re^3: RFC: Module - GSM::Nbit
by toolic (Chancellor) on May 14, 2010 at 12:44 UTC
    As of world writable files - that would be a bugger to figure out on my own. But looking at my folder structure I have standard chmod 644 for files and 755 for folders. So I'm not sure what's wrong?
    To be honest, I do not understand why this is necessary. But, I do know that one of my uploaded tar files was rejected by CPAN testers because of a permission problem. When I ran bart's script on my tar file, the problem disappeared. I have used it on every upload since, and I have not had a repeat of the problem. It's easy to run, and it helps avoid hassles. Why not just do it?
    First point I don't completely agree on - I believe INSTALLATION section is there for the CPAN web page?
    INSTALLATION belongs in the README file, and you already have it there. I see no reason to duplicate it in your POD. Look at the POD for your 10 favorite modules. Do you see an INSTALLATION section in any of them?
    perldoc List::MoreUtils

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://839943]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others romping around the Monastery: (9)
As of 2014-09-22 21:15 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    How do you remember the number of days in each month?











    Results (202 votes), past polls