|No such thing as a small change|
Re^2: RFC: Module - GSM::Nbitby techcode (Hermit)
|on May 14, 2010 at 06:05 UTC||Need Help??|
Yeah - there are some typos as I still need to run it through a spell checker (and perlcritic) - any tools for that?EDIT: perlcritic does a nice job of spell checking as well :)
I had the code indented, but then in man pages it looked like double indented from being inside a section + code indentation itself. But I agree it looks better that way so reverting + removing spaces between variable, = and value.
Yes for more data validation - I also "unified" so everything just does "return unless xyz;" instead of having both that and "return '' unless xyz;" in a few places.
Agree on examples directory :)
As of world writable files - that would be a bugger to figure out on my own. But looking at my folder structure I have standard chmod 644 for files and 755 for folders. So I'm not sure what's wrong?
First point I don't completely agree on - I believe INSTALLATION section is there for the CPAN web page?