Re^2: Object::InsideOut leaks memory when using threads::shared

[menth0l]

Jerry D. Hedden has already answered to my bug report. He states that:

(...)it's not an OIO bug. It's a problem with the perl interpreter and/or threads::shared.

He managed though to fix this in new OIO version that he ut on CPAN (1.71):
http://cpansearch.perl.org/src/JDHEDDEN/Object-InsideOut-3.71/Changes

Thank you all for help and thanks to Jerry for quick reaction!

[BrowserUk]

it's not an OIO bug. It's a problem with the perl interpreter and/or threads::shared.

Interesting fix/workaround:

@@ -634,19 +634,23 @@
 
     # Save deleted IDs for later reuse
     my $reuse = $GBL{'id'}{'reuse'};
+    lock($reuse) if $GBL{'share'}{'ok'};
     if ($id) {
-        lock($reuse) if $GBL{'share'}{'ok'};
         if (! exists($$reuse{$tree})) {
             $$reuse{$tree} = make_shared([]);
         }
         my $r_tree = $$reuse{$tree};
         if (! exists($$r_tree[$thread_id])) {
-            $$r_tree[$thread_id] = make_shared({});
-        } elsif (exists($$r_tree[$thread_id]{$id})) {
-            warn("ERROR: Duplicate reclaimed object ID ($id) in class
+ tree for $tree in thread $thread_id\n");
-            return;
+            $$r_tree[$thread_id] = make_shared([]);
+        } else {
+            foreach  (@{$$r_tree[$thread_id]}) {
+                if ($_ == $id) {
+                    warn("ERROR: Duplicate reclaimed object ID ($id) 
+in class tree for $tree in thread $thread_id\n");
+                    return;
+                }
+            }
         }
-        $$r_tree[$thread_id]{$id} = $id;
+        push(@{$$r_tree[$thread_id]}, $id);
         return;
     }
 
@@ -654,9 +658,9 @@
     if (exists($$reuse{$tree}) &&
         exists($$reuse{$tree}[$thread_id]))
     {
-        keys(%{$$reuse{$tree}[$thread_id]});
-        if ((my $id) = each(%{$$reuse{$tree}[$thread_id]})) {
-            return (delete($$reuse{$tree}[$thread_id]{$id}));
+        my $id = pop(@{$$reuse{$tree}[$thread_id]});
+        if (defined($id)) {
+            return $id;
         }
     }