Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl Monk, Perl Meditation

Re: Need help with comparison code

by GotToBTru (Prior)
on Feb 02, 2011 at 18:16 UTC ( #885811=note: print w/replies, xml ) Need Help??

in reply to Need help with comparison code

You have opened both IN and OUT using the same mode. You probably mean:
open IN,'<',$matchfile or die "Could not open $matchfile\n"; open OUT,'>>,$outfile or die "Could not open $outfile\n";
Foreach syntax: foreach $var (@array)
For syntax: for (expression; condition; control)
I think you want to use two foreach commands here:
foreach my $file (@files) { foreach my $file2 (<IN>) {

Replies are listed 'Best First'.
Re^2: Need help with comparison code
by GrandFather (Sage) on Feb 03, 2011 at 03:52 UTC

    for/foreach (<$fh>) is generally a bad idea - it implies slurping the file and creating a list of lines internally. Better is to use a while (<$fh>) loop. In both cases the loop body handles things a line at a time, but while is a better semantic match and is likely to be much more memory (and possibly slightly more time) efficient.

    True laziness is hard work
Re^2: Need help with comparison code
by Gulliver (Monk) on Feb 02, 2011 at 18:52 UTC

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://885811]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others exploiting the Monastery: (6)
As of 2017-11-21 02:52 GMT
Find Nodes?
    Voting Booth?
    In order to be able to say "I know Perl", you must have:

    Results (294 votes). Check out past polls.