Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change

Re^2: SMTP "auth" problem after upgrade

by SimonClinch (Deacon)
on May 13, 2011 at 16:05 UTC ( #904695=note: print w/replies, xml ) Need Help??

in reply to Re: SMTP "auth" problem after upgrade
in thread SMTP "auth" problem after upgrade

Apart from the fact that $smtp is scoped out of existence and Noauth being tested for defined looks like a tautology in this snippet, I would be inclined to factorise out the "unless" in such a situation where most of the lines of code in the two branches are identical, and use a tertiary operator instead :
my $smtp = MIME::Lite->send('smtp', $host, defined( $something_else ) ? AuthUser => $user, AuthPass => $pass : Noauth => 1, Debug => 1 );

One world, one people

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://904695]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others about the Monastery: (2)
As of 2016-10-24 04:07 GMT
Find Nodes?
    Voting Booth?
    How many different varieties (color, size, etc) of socks do you have in your sock drawer?

    Results (302 votes). Check out past polls.