Beefy Boxes and Bandwidth Generously Provided by pair Networks
good chemistry is complicated,
and a little bit messy -LW

Re^2: SMTP "auth" problem after upgrade

by SimonClinch (Chaplain)
on May 13, 2011 at 16:05 UTC ( #904695=note: print w/ replies, xml ) Need Help??

in reply to Re: SMTP "auth" problem after upgrade
in thread SMTP "auth" problem after upgrade

Apart from the fact that $smtp is scoped out of existence and Noauth being tested for defined looks like a tautology in this snippet, I would be inclined to factorise out the "unless" in such a situation where most of the lines of code in the two branches are identical, and use a tertiary operator instead :

my $smtp = MIME::Lite->send('smtp', $host, defined( $something_else ) ? AuthUser => $user, AuthPass => $pass : Noauth => 1, Debug => 1 );

One world, one people

Comment on Re^2: SMTP "auth" problem after upgrade
Download Code

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://904695]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others chilling in the Monastery: (11)
As of 2015-11-30 11:33 GMT
Find Nodes?
    Voting Booth?

    What would be the most significant thing to happen if a rope (or wire) tied the Earth and the Moon together?

    Results (769 votes), past polls