Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling
 
PerlMonks  

Re^2: SMTP "auth" problem after upgrade

by SimonClinch (Chaplain)
on May 13, 2011 at 16:05 UTC ( #904695=note: print w/ replies, xml ) Need Help??


in reply to Re: SMTP "auth" problem after upgrade
in thread SMTP "auth" problem after upgrade

Apart from the fact that $smtp is scoped out of existence and Noauth being tested for defined looks like a tautology in this snippet, I would be inclined to factorise out the "unless" in such a situation where most of the lines of code in the two branches are identical, and use a tertiary operator instead :
my $smtp = MIME::Lite->send('smtp', $host, defined( $something_else ) ? AuthUser => $user, AuthPass => $pass : Noauth => 1, Debug => 1 );

One world, one people

Comment on Re^2: SMTP "auth" problem after upgrade
Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://904695]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others pondering the Monastery: (12)
As of 2016-04-28 20:34 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    :nehw tseb si esrever ni gnitirW







    Results (435 votes). Check out past polls.