Beefy Boxes and Bandwidth Generously Provided by pair Networks
go ahead... be a heretic
 
PerlMonks  

Re^11: XS: EXTEND/mPUSHi

by syphilis (Canon)
on Sep 29, 2011 at 12:39 UTC ( #928545=note: print w/ replies, xml ) Need Help??


in reply to Re^10: XS: EXTEND/mPUSHi
in thread XS: EXTEND/mPUSHi

Heh - I must've looked at the C code a hundred times over the years, and never noticed the unreached

PUTBACK; return;
... though, as I write this, I'm suddenly struck with a contradictory sense of "deja vu".

That unreached code *is* confusing and/or annoying, and it would be nice to make that piece of xsubbp-generated code reachable (as you suggest) - which means amending C.pm in a way that makes me feel a bit uneasy.

Your 'do nothing' was probably the right call

Maybe ... I *have* been right before, y'know !! ... by accident, of course ( ... which would also be the case in this instance :-)

I'll chew this over for a while, as time permits. I've already checked that ikegami's suggested changes re the "no-op" and the "PUTBACK" insertions don't break the test suite. (However, they still leave us with that unreached "return" ... not that he suggested they would do otherwise.)

Thanks BrowserUk, ikegami.

Cheers,
Rob


Comment on Re^11: XS: EXTEND/mPUSHi
Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://928545]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others chanting in the Monastery: (6)
As of 2014-11-28 07:23 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    My preferred Perl binaries come from:














    Results (193 votes), past polls