Beefy Boxes and Bandwidth Generously Provided by pair Networks Frank
The stupid question is the question not asked
 
PerlMonks  

Re^3: where is sv_setrv?

by ikegami (Pope)
on Dec 19, 2011 at 07:20 UTC ( #944217=note: print w/ replies, xml ) Need Help??


in reply to Re^2: where is sv_setrv?
in thread where is sv_setrv?

Your version of newSVrv wouldn't work [before Perl 5.12]

It's not a version of newSVrv, and you're free to do the exercise yourself for 5.10.

Can RVs have a PV string pointer

Like you just said, there's no such thing as an RV anymore.

Does an RV always have to be of type SVt_IV (5.12) or any SV with ROK can be a reference?

Latter. Even before 5.12.

The sv_replace seems like the safest idea while i'm writing this.

That's quite an understatement.

There is a missing refcount inc on sv before "SvRV_set(rv, sv);".

You're saying that newSVrv causes referenced material to be destroyed permaturely. I don't believe you.


Comment on Re^3: where is sv_setrv?
Download Code
Re^4: where is sv_setrv?
by patcat88 (Chaplain) on Dec 20, 2011 at 16:49 UTC
    There is a missing refcount inc on sv before "SvRV_set(rv, sv);".

    You're saying that newSVrv causes referenced material to be destroyed permaturely. I don't believe you.


    In newSVrv, a new target SV is created at sv.c#l9268 in perl.git. In a hypothetical setsv_rv you need to up the refcount of the EXISTING target SV that the reference will point to or the existing target SV will get garbage collected prematurely, and we arent making a weak reference here, or your following hv_store standard where the caller has to up the refcount (or do nothing with newSV) of the sv before passing to the func?
      Fixed.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://944217]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others chanting in the Monastery: (8)
As of 2014-04-17 02:18 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    April first is:







    Results (437 votes), past polls