Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical

Re^6: Listing of files using glob

by AG87 (Acolyte)
on Jan 05, 2012 at 11:56 UTC ( #946379=note: print w/ replies, xml ) Need Help??

in reply to Re^5: Listing of files using glob
in thread Listing of files using glob

No I am not. Here is the code used to store the file into hash

open(FILE, "$path_to_fastaSeqs") or die("cannot open file"); { while(<FILE>) { my $line = $_; if ($line =~ />.*/) { #print "$&\n"; } else { #print "$line\n"; } $seqInfo{$&} = $line; } close(FILE); }

Any errors or wrong approach??

Comment on Re^6: Listing of files using glob
Download Code
Replies are listed 'Best First'.
Re^7: Listing of files using glob
by MidLifeXis (Monsignor) on Jan 05, 2012 at 13:26 UTC

    > Any errors or wrong approach??

    Yep. You never chomp the data read from the filehandle FILE. Since you are building the file name directly from the line read, it most likely contains a newline. If you print your value for $line with a delimiter surrounding it (print "'$line'\n";) you will see what I mean. See chomp (as has been previously mentioned) for a solution.

    Update: Since the OP is using $& to populate the hash, and the processing loop uses the keys of the hash as the name of the file, the newline from the file should not be included in the hash key. Nice catch choroba

    I wonder what the line endings are in the data file. Is it possible that the file is in DOS line ending format? In which case, the chomp (and $&?) would not do the right thing.


      It's a bit more complicated. The OP uses $& as the hash key after matching />.*/, which removes the newline (as . does not match a newline), but it can overwrite a previous hash value if the line does not match, which we cannot tell without seeing the input data.

        Aaah, quite right. I am curious about the line endingness of FILE then (in which case, chomp would not do the right thing either :-/ )


        The input data is like


        Where >1elwA, >1flwA, >1ghwA should be the keys of the hashes and the respective data should be the value of the hash. The code/sub for storing in the file is

        #!/usr/bin/perl my %seqInfo = (); open(FILE, 'test.fasta'); { while(<FILE>) { my $line = $_; if ($line =~ />.*/) { #print "$&\n"; } else { #print "$line\n"; } $seqInfo{$&} = $line; print "$& => $line\n"; } }

        and the output is


        However according to my understanding the output should be like


        Maybe the file is not properly stored as keys and values :( :(

Re^7: Listing of files using glob
by choroba (Canon) on Jan 05, 2012 at 13:22 UTC
    Can you show the input, too?

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://946379]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others wandering the Monastery: (5)
As of 2015-11-28 16:08 GMT
Find Nodes?
    Voting Booth?

    What would be the most significant thing to happen if a rope (or wire) tied the Earth and the Moon together?

    Results (743 votes), past polls