Beefy Boxes and Bandwidth Generously Provided by pair Networks
There's more than one way to do things
 
PerlMonks  

Re^2: Safer monkey-patching

by tobyink (Abbot)
on Jan 19, 2012 at 10:30 UTC ( #948743=note: print w/ replies, xml ) Need Help??


in reply to Re: Safer monkey-patching
in thread Safer monkey-patching

Redefining a function only produces a warning if "use warnings" is in effect. So classic monkey patching will not necessarily produce compile-time warnings.

If a conflict warning is desired, that's fairly easy to add in with my method...

BEGIN { require Example::Error; foreach my $method (qw/asplode/) { warn "Example::Error->$method already defined." if Example::Error->can($method); } push @Example::Error::ISA, __PACKAGE__; }


Comment on Re^2: Safer monkey-patching
Download Code
Re^3: Safer monkey-patching
by JavaFan (Canon) on Jan 19, 2012 at 10:58 UTC
    Redefining a function only produces a warning if "use warnings" is in effect. So classic monkey patching will not necessarily produce compile-time warnings.
    Are you serious? You consider that a reasonable argument? "You shouldn't monkey patch because you may not get a warning on a name clash if you don't enable warnings"?

    I'm pretty sure that anyone who knows how to monkey patch knows about warnings.

    If a conflict warning is desired, that's fairly easy to add in with my method...
    Goody. Additional scaffolding, and you still aren't any further than what can be achieved with monkey-patching.

    Assuming Example::Error doesn't use AUTOLOAD to implement asplode (heh, if you want to consider monkey patchers that don't enable warnings, I will consider AUTOLOAD), it still doesn't solve anything. Once Example::Error implements asplode, you get a warning, and where your code expects to call your asplode, it calls Example::Error::asplode. Ergo, you haven't solved anything. It isn't safer than monkey-patching. With the extra scaffolding, it isn't unsafer either.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://948743]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others drinking their drinks and smoking their pipes about the Monastery: (10)
As of 2015-07-07 11:17 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









    Results (88 votes), past polls