Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl: the Markov chain saw
 
PerlMonks  

Re: Code Review Time!

by jwkrahn (Monsignor)
on Mar 14, 2012 at 22:54 UTC ( #959684=note: print w/ replies, xml ) Need Help??


in reply to Code Review Time!

When I compile your code I get:

$ perl -c 959680.pl Type of arg 1 to push must be array (not scalar dereference) at 959680 +.pl line 95, near "@list;" Type of arg 1 to push must be array (not scalar dereference) at 959680 +.pl line 96, near "@callers;" Type of arg 1 to push must be array (not scalar dereference) at 959680 +.pl line 112, near "@list;" 959680.pl had compilation errors.

Which refers to these three lines:

95 push $id, @list; 96 push $id, @callers; 112 push $id, @list;

The first argument to push must be an array.    Perhaps you meant:

95 push @list, $id; 96 push @callers, $id; 112 push @list, $id;


If I enable warnings I get these messages:

$ perl -Mwarnings -c 959680.pl Name "main::key" used only once: possible typo at 959680.pl line 232. Name "main::savestate" used only once: possible typo at 959680.pl line + 65. Name "main::job_list" used only once: possible typo at 959680.pl line +123. Name "main::message" used only once: possible typo at 959680.pl line 6 +3. 959680.pl syntax OK


Comment on Re: Code Review Time!
Select or Download Code
Re^2: Code Review Time!
by linuxkid (Sexton) on Mar 15, 2012 at 01:02 UTC
    Code review really wasn't the topic, but that wasn't the problem I was having. I was wondering about the Tk error, but thanks.

    --linuxkid


    imrunningoutofideas.co.cc

      linuxkid:

      If code review wasn't the topic you wanted, then you made an odd title choice! ;^D

      ...roboticus

      When your only tool is a hammer, all problems look like your thumb.

        I tend to like to mess with people on occasion, so i use wierd titles to do that, not just here, emails, stuff like that annoys everyone.

        --linuxkid


        imrunningoutofideas.co.cc
Re^2: Code Review Time!
by Anonymous Monk on Mar 15, 2012 at 08:35 UTC

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://959684]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others making s'mores by the fire in the courtyard of the Monastery: (4)
As of 2014-09-15 03:41 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    My favorite cookbook is:










    Results (145 votes), past polls