Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl Monk, Perl Meditation

Re: Code Review Time!

by davido (Archbishop)
on Mar 14, 2012 at 23:13 UTC ( #959688=note: print w/ replies, xml ) Need Help??

in reply to Code Review Time!

Your question's title "Code Review Time!" gives me the impression you're looking for comments on the code. But the body of your post seems to be asking a question about a specific error, which is quite different from a code review. Which would you prefer?

If you're really looking for a code review, start with Perl::Critic. Install the module, then "perlcritic" Once you resolve any of the critiques there that make sense for your particular code (such as code before strictures), and once your code can be run with 'warnings' and 'strict', without generating warnings and errors, you might be ready for a human code review, although I would first re-run perlcritic at a stronger severity level, addressing as many of the additional critiques it comes up with as is practical. I've found that it isn't always relevant, possible, or wise to apply all of its advice, but at least looking at the advice and making conscious decisions about whether or not to take further action is an exercise that sometimes helps to uncover bugs and maintainability shorcomings.

But until then I think you should probably be asking a question that is more specific to the nature of the error you're getting. For that, I think we would need more information, and a code snippet that just produces the error without a bunch of unnecessary code for us to sift through. In particular, you need to try to narrow down the list of dependencies needed to produce the error. I'd rather not install a whole bunch of modules I don't need, but wouldn't be opposed to installing the one or two that are required to replicate the error. You may even find that in trying to narrow the code down to the smallest test case that can possibly produce the error, you'll find out what the error actually is.

Update: I do have one other thought though; when I installed Tk (Strawberry/Windows) I find that it won't even pass its own test suite, nor will several of the modules you're using. If you installed with the 'force' option to make it install despite failing its test suite (as opposed to actually fixing all the problems), you may just be reaping what you sewed.


Comment on Re: Code Review Time!
Download Code
Replies are listed 'Best First'.
Re^2: Code Review Time!
by linuxkid (Sexton) on Mar 15, 2012 at 01:11 UTC
    well, yes i forced. but this was going to be pacaged with pp for a standalone executable for a charity i work with that make alot of calls. now i have to fanagle with stuff


Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://959688]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others rifling through the Monastery: (3)
As of 2016-05-01 14:33 GMT
Find Nodes?
    Voting Booth?

    No recent polls found