Re^4: reading and working with grow.out files

[rmgzsm9]

in reply to Re^3: reading and working with grow.out files
in thread reading and working with grow.out files

I made this program, but it is giving so many errors. Can you help me in debugging it.

use strict;
use warnings;
use Carp qw(croak);
{
    my $input_file = "input_file.txt";
    my @lines = slurp($input_file);
    for my $line (@lines){
        my ($filename, $ligand) = split(/\t/, $line);
        open(FILE, '<', $filename) or die "Cannot open file: $!";
        
        while (my $line = <FILE>) {
            if ($line =~ /$ligand/)
            {
            $count++;
            $first=substr($line, 0,1);
            if($first=='H');
            {
            $sum++;
            }
            }
            print "Total No. of interactions are $count";
            print " No. of Hydrogen bonds are $sum";
        }
        close(FILE);
    }   
}

##Slurps a file into a list
sub slurp {
    my ($file) = @_;
    my (@data, @data_chomped);
    open IN, "<", $file or croak "can't open $file\n";
    @data = <IN>;
    for my $line (@data){
        chomp($line);
        push (@data_chomped, $line);
    }
    close IN;
    return (@data_chomped);
}

[marto]

The messages you receive tell exactly what's wrong:

Global symbol "$count" requires explicit package name at test.pl line 
+14.
Global symbol "$first" requires explicit package name at test.pl line 
+15.
Global symbol "$first" requires explicit package name at test.pl line 
+16.
syntax error at test.pl line 16, near ");"
Global symbol "$sum" requires explicit package name at test.pl line 18
+.
Global symbol "$count" requires explicit package name at test.pl line 
+21.
Global symbol "$sum" requires explicit package name at test.pl line 22
+.

Define $count, $first and $sum, like the other variables in your script. For example, add the following line in the appropriate place:

my ($count, $first, $sum);

Next, No semi colon required here:

if ($first=='H');
{

Should be:

if ($first=='H')
{

I suggest spending some time working on the basics:

• perlintro
• http://learn.perl.org
• http://perldoc.perl.org
• Browse the Tutorials section of this site.

[rmgzsm9]

Thanks. It worked. Not exactly I wanted, but it worked

[marto]

Telling you how to fix the code you provided wasn't exactly what you wanted, or your code doesn't do what you want?