Beefy Boxes and Bandwidth Generously Provided by pair Networks
Syntactic Confectionery Delight

Re^7: difficulty in matching 2 fields of a same line

by muba (Priest)
on Jun 27, 2012 at 19:09 UTC ( #978749=note: print w/replies, xml ) Need Help??

in reply to Re^6: difficulty in matching 2 fields of a same line
in thread difficulty in matching 2 fields of a same line

You should make every progam begin with those two lines, unless you have a very good reason not to. It will force you to write cleaner code, helping you catch errors much quicker. Originally you did that, but somewhere along the road, it seemed, you dropped these lines.

use strict; use warnings;


This looks okay.

print "\n Enter the file name :>"; chomp( my $filename1 = <STDIN> );


Because we use strict; we'll have to declare the array now. You did it right in the original code, but again, somewhere you strayed from the right path.

my @lines = ();


I really disagree with the exact wording of the error message here. As I've pointed out in the other threat. But bah. If this is how ya wanna put it, don't lemme stop ya!

open my $fh, '<', $filename1 or die "Cannot find the file $filename1: +$!";


I'm tempted to rewrite your loop so that it writes out lines as it reads them. There's really no point in keeping things in-memory, but I'll assume you have a reason for doing it this way. At any rate I'm getting rid of your $count variable. You don't really need it. This, too, has been pointed out in that other threat.

while (<$fh>) { push @lines, $_; }

Or just push @lines, $_ while <$fh>;. Or, while we're at it. @lines = <$fh>;, as has been mentioned in... you know where. Anyway, I've moved this close statement up. There's no point in keeping the file handle open if you're not using it anymore anyway.

close $fh;


This looks okay.

open my $w, '>', 'Result.txt' or die "Cannot open the file Result.txt: + $!";


I've rewritten your for loop to be more Perl-ish. This, too, has been demonstrated.

foreach my $line (@lines) { my @chr_fields = grep {$_ =~ m/^chr/} split ("\t", $line) if ( # If... @chr_fields == 2 # ...there are exactly two +chr* fields... && $chr_fields[0] ne $chr_fields[1] # ...which are not exactly +the same... ) { print $w $line; } } close $w;

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://978749]
talexb thinks the term 'cookie monster' is unnecessarily drogatory ;) and takes a cookie as well. Mmmm. Delicious cookies.
[davido]: A tool as pretentious as Test::Perl::Critic ought not fail to install because one of its dependencies failed to pull in List::MoreUtils.
[davido]: ...and

How do I use this? | Other CB clients
Other Users?
Others chilling in the Monastery: (11)
As of 2017-04-25 16:02 GMT
Find Nodes?
    Voting Booth?
    I'm a fool:

    Results (458 votes). Check out past polls.