|Welcome to the Monastery|
refactor newlistapproved to absorb newmoderatelistby jdporter (Canon)
|on Jul 13, 2012 at 13:31 UTC||Need Help??|
jdporter has raised the following topic:
Update: The below has been done. You may disregard. :-)
I propose merging the code of newmoderatelist back into newlistapproved, and add an option parameter which would tell newlistapproved whether to call votefoot at the appropriate point. There is already an option parameter, showunapproved, which controls whether to show the unapproved list.
In order to grasp all the ramifications across the site, I prepared the following table, which summarizes the code of each place newlistapproved is currently used (excluding test nodes and such).
Table is presented in a reply below.
Based on this data, I believe this change would be safe and straightforward to make. The only real oddball we'd have to worry about is Editor Requests, but I think we could handle that.
I think this change will make the code simpler, but perhaps more importantly, more efficient. The overhead cost of calling an htmlcode is substantial. It includes the cost of (a) retrieving the node from the database, and (b) executing a perl eval.
I reckon we are the only monastery ever to have a dungeon stuffed with 16000 zombies.