Beefy Boxes and Bandwidth Generously Provided by pair Networks
laziness, impatience, and hubris

Re^2: refactor newlistapproved to absorb newmoderatelist

by jdporter (Canon)
on Jul 13, 2012 at 17:02 UTC ( #981667=note: print w/replies, xml ) Need Help??

in reply to Re: refactor newlistapproved to absorb newmoderatelist
in thread refactor newlistapproved to absorb newmoderatelist

well, newmoderatelist is never used except after calling newlistapproved with the showunapproved option. keeping them together reduces the likelihood of bugs. ANd I think it reduces surprise. Understanding that newmoderatelist was a "continuation" of newlistapproved was something of a revelation for me.

I could see the advantage of doing it that way if it was to "jump over" some large and/or variable chunk of code, but it doesn't. It always only jumps over votefoot. And now that votefoot is gone from there, there is absolutely no reason for the continuation code to be in a separate htmlcode node.

Merging the code, as in the patches I just submitted, actually reduces code complexity a bit. For one thing, there's no need to shove the "passed" data into %HTMLVARS anymore.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://981667]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others wandering the Monastery: (8)
As of 2018-03-18 13:54 GMT
Find Nodes?
    Voting Booth?
    When I think of a mole I think of:

    Results (230 votes). Check out past polls.