Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling

Re: a quick stab at a public links page

by CharlesClarkson (Curate)
on Jul 22, 2001 at 20:35 UTC ( #98836=note: print w/replies, xml ) Need Help??

in reply to a quick stab at a public links page

I took a closer look at your script and you don't need CGI::Vars at all. You may want to read the documentation on Your missing a lot of oppurtunities. Here are few corrections that may have you up and going quickly.

On this line we're creating %params.
my (%params) = $query->Vars; has a function for this: param. To access any parameter, just call param('any'). To use it as a function we need to change use CGI; to use CGI qw/param/;

Now that we can access param directly, let's make a few changes.

my ($command) = $params{'command'}; touch() if ($command eq "touch"); addlink() if ($command eq "add");
touch() if param('command') eq 'touch'; addlink() if param('command') eq 'add';
errorpage("You must fill in both fields!") if (($params{'name'} eq "") || ($params{'url'} eq ""));
errorpage('You must fill in both fields!') if param('name') eq '' || param('url') eq '';
print FILE $params{'name'}." ".$params{'url'}."\n";
becomes: print FILE param('name'), ' ', param('url'), "\n";

Charles K. Clarkson

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://98836]
[marto]: good morning all, snow day here, won't make it to the office
[Corion]: marto: Oof - that means taking a day off or can you work from home?

How do I use this? | Other CB clients
Other Users?
Others pondering the Monastery: (8)
As of 2018-01-16 08:45 GMT
Find Nodes?
    Voting Booth?
    How did you see in the new year?

    Results (175 votes). Check out past polls.