Beefy Boxes and Bandwidth Generously Provided by pair Networks
good chemistry is complicated,
and a little bit messy -LW
 
PerlMonks  

Re^2: Looking for pointers or optimizations.

by nemesdani (Friar)
on Aug 21, 2012 at 13:50 UTC ( #988735=note: print w/ replies, xml ) Need Help??


in reply to Re: Looking for pointers or optimizations.
in thread Looking for pointers or optimizations.

"First, you should always explicitly close any filehandle"
...not to mention checking your filenhandle in the first place ;)

open (INP, "<", "$filename") or die "cannot open input file";

Another thing: you use @ARGV in scalar context - I doubt that this is what you want.


I'm too lazy to be proud of being impatient.


Comment on Re^2: Looking for pointers or optimizations.
Download Code
Re^3: Looking for pointers or optimizations.
by MidLifeXis (Prior) on Aug 21, 2012 at 14:28 UTC
    open (INP, "<", "$filename") or die "cannot open input file";

    You may want to

    • not interpolate the variable, just use it as is - why restringify something that you think should already be a string.
    • use lexical file handles - it will allow it to fall out of scope rather than being a global. Forcing yourself to think of the scoping of variables can be good when trying to make your code modular.
    • include the error message in the error response - it will help to debug why the file was not able to be opened. Was it due to too many files being opened, permissions being wrong on the file, the file not existing, sunspots...?

    Update: I see that the OP has done two of the three of these already -- this comment is targeted at the parent post. :-)

    open (my $inputFH, "<", $filename) or die "cannot open input file: $!";

    --MidLifeXis

      Yeah, I asked for it :).
      Thanks.

      I'm too lazy to be proud of being impatient.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://988735]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others wandering the Monastery: (6)
As of 2014-08-30 10:58 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The best computer themed movie is:











    Results (293 votes), past polls