Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical
 
PerlMonks  

Re^3: Looking for pointers or optimizations.

by MidLifeXis (Prior)
on Aug 21, 2012 at 14:28 UTC ( #988758=note: print w/ replies, xml ) Need Help??


in reply to Re^2: Looking for pointers or optimizations.
in thread Looking for pointers or optimizations.

open (INP, "<", "$filename") or die "cannot open input file";

You may want to

  • not interpolate the variable, just use it as is - why restringify something that you think should already be a string.
  • use lexical file handles - it will allow it to fall out of scope rather than being a global. Forcing yourself to think of the scoping of variables can be good when trying to make your code modular.
  • include the error message in the error response - it will help to debug why the file was not able to be opened. Was it due to too many files being opened, permissions being wrong on the file, the file not existing, sunspots...?

Update: I see that the OP has done two of the three of these already -- this comment is targeted at the parent post. :-)

open (my $inputFH, "<", $filename) or die "cannot open input file: $!";

--MidLifeXis


Comment on Re^3: Looking for pointers or optimizations.
Select or Download Code
Re^4: Looking for pointers or optimizations.
by nemesdani (Friar) on Aug 21, 2012 at 14:36 UTC
    Yeah, I asked for it :).
    Thanks.

    I'm too lazy to be proud of being impatient.

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://988758]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others pondering the Monastery: (7)
As of 2014-07-23 22:13 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    My favorite superfluous repetitious redundant duplicative phrase is:









    Results (153 votes), past polls