Re: Paths::Graph use

[RMGir]

in reply to Paths::Graph use

I don't think

my %graph = <FILE>

does what you think it does...

I think that will get you a "%graph" hash with the first line as a key, the 2nd line as a value, and so on so forth...

Try adding this right after you load %graph and see what it prints:

foreach my $k(keys %graph) {
    print "<<<<<\n$k     ===>>>>  $graph{$k}\n>>>>>\n"
}

[zakishah]

Thank you very much , but my purpose is not to print file here, my purpose is to read file and calculate the shortest distance between desitantion and origin, which my code is not calculating the problem is not with path calculation here but it is in reading file. Please suggest on this issue.

[RMGir]

Why not structure your data as correct perl, then just read it in and eval it?

# data file
(
    # Quoting the dotted quads since => will not quote 
    # those correctly
    '10.0.0.128' =>
        {
           '10.0.0.129'=>3,
           '10.0.0.129'=>4,
           '10.0.0.130'=>3,
           '10.0.0.131'=>2,
           '10.0.0.132'=>1,
           '10.0.0.133'=>1,
           '10.0.0.134'=>2,
           '10.0.0.135'=>4,
           '10.0.0.136'=>1,
           '10.0.0.137'=>4,
           '10.0.0.138'=>3
        },
    '10.0.0.129' =>
        {
           '10.0.0.128'=>3,
           '10.0.0.130'=>1,
           '10.0.0.131'=>2,
           '10.0.0.132'=>1,
           '10.0.0.133'=>2,
           '10.0.0.134'=>1,
           '10.0.0.135'=>2,
           '10.0.0.136'=>3, # the > was missing on this line...
           '10.0.0.137'=>3,
           '10.0.0.138'=>4
        },
);

Now your reading code can simply be:

my $x=join "",<FILE>;
my %graph = eval $x;

[afoken]

Now your reading code can simply be:

my $x=join "",<FILE>; 
my %graph = eval $x;

Please don't use string-eval to read data files. CPAN has several data file readers that don't crash your program or erase your harddisk if the data file contains unexpected data. Think about JSON, YAML, or, if you have no better idea, XML. None of those formats is read as executable code.

And if you really can't avoid string-eval, at least use Safe in a "deny-almost-everything" configuration.

Alexander