Beefy Boxes and Bandwidth Generously Provided by pair Networks
Welcome to the Monastery

Re: Improve my lookup script

by GlitchMr (Sexton)
on Aug 22, 2012 at 15:14 UTC ( #989073=note: print w/replies, xml ) Need Help??

in reply to Improve my lookup script

You can use CPAN module, such as List::BinarySearch instead of writing code yourself.

Also, instead of using min and max you could use $array[0] and $array[-1] - the list is sorted.

Also, as far I can see, you check if value is out of bounds every time loop passes. You can move this check outside loop.

Replies are listed 'Best First'.
Re^2: Improve my lookup script
by jjap (Monk) on Aug 22, 2012 at 15:46 UTC
    Indeed all very good points!

    Thanks for pointing me to List::BinarySearch.

     bsearch_num_pos($lookup, @array) gives me a grip to handle further calculations.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://989073]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others lurking in the Monastery: (5)
As of 2018-05-26 16:08 GMT
Find Nodes?
    Voting Booth?