Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change

Re^5: Regex: Identifying comments

by remiah (Hermit)
on Aug 31, 2012 at 05:37 UTC ( #990924=note: print w/replies, xml ) Need Help??

in reply to Re^4: Regex: Identifying comments
in thread Regex: Identifying comments


You will not see my regex fault with your examples. My regex will stumble with this sql.

update set bar = bar - 1 ; -- subtraction symbol may disappear.

I expected to see SQL parser solution in this thread, like this

my $p = SQLParser->new(type=>'mysql', sql=>$sql) or die SQLParser->error(); $p->prettyprint(1); $p->without_comment(1); print $p->sql;
At first I looked SQL::Parser. It seems quite near for such tasks, but I couldn't find good solution to rip off comments. Do you know such module?

Replies are listed 'Best First'.
Re^6: Regex: Identifying comments
by pvaldes (Chaplain) on Aug 31, 2012 at 15:32 UTC
    use strict; use warnings; while (<DATA>) { chomp; next if /^\s*--/; print $_,"\n" if !/--/; elsif (/--/ && !/--(.*?);/){ s/--(.*?)$//; print $_,"\n"} elsif (/--(.*?);\s*--(.*?)$/){ s/\s*--$2//; print $_,"\n"} else { print $_,"\n"} } __DATA__ select 'text' from foo; -- comment select '--Not comment' from foo; --But this is select q from z; -- as is this select '--Not this' + '--either' from foo; select 'qaws' + make from "a"; -- comment with 'a' quote select 'a' from 'b' with 'c' -- comment with 'a --' comment -- test comment (add1) select 'text\'s' from foo --escaped ... (add2) select 'text\'s' from foo --escaped' ... (add3) update set bar = bar - 1 ; -- subtraction symbol preserved create table ( -- fo field text, -- fufufu field int)

      I think you need to revisit this...

      syntax error at line 7, near "elsif" syntax error at line 10, near "elsif" syntax error at line 12, near ""\n"}" Execution of aborted due to compilation errors.
        first elsif should probably be "if" only

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://990924]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others scrutinizing the Monastery: (3)
As of 2018-05-20 20:12 GMT
Find Nodes?
    Voting Booth?