Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl-Sensitive Sunglasses
 
PerlMonks  

Re: compare text files

by roboticus (Canon)
on Sep 12, 2012 at 01:11 UTC ( #993102=note: print w/ replies, xml ) Need Help??


in reply to compare text files

linseyr:

You've got two nested loops, and you're reading the *entire* second file before reading the next line of the first file. But since the second file has been read in its entirety, the second loop will fail from that point on.

There are a good few approaches you could use:

  • Read both files into an array and iterate over the arrays. (Easy, but "inelegant".)
  • Sort both input files by the matching column and then use a single loop, consuming the line having the lowest key value. (A *little* tricky.)
  • Rewind/reopen the second file each iteration. (Ugly.)
  • Read both files into hashes using your key column as the hash key, and then process the hashes. (Usually a good way, but your data has duplicate keys, so it wouldn't be very helpful in this case.)

In this case, I'm thinking you'll probably be best off with the first suggestion.

Update: You may want to put a few print statements in your program so you can see what's happening.

...roboticus

When your only tool is a hammer, all problems look like your thumb.


Comment on Re: compare text files

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://993102]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others taking refuge in the Monastery: (10)
As of 2014-12-29 13:52 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    Is guessing a good strategy for surviving in the IT business?





    Results (188 votes), past polls