Beefy Boxes and Bandwidth Generously Provided by pair Networks
Problems? Is your data what you think it is?

Re: Any improvement over the code possible??

by Kenosis (Priest)
on Sep 21, 2012 at 18:00 UTC ( #994961=note: print w/replies, xml ) Need Help??

in reply to Any improvement over the code possible??

Consider the following:

sub find_above_average { my $mean = &calculate_average(@_); return grep $_ > $mean, @_; }

Remove the say line and print the average outside of the subroutine, and use grep to return only those values greater than the value of $mean.

sub calculate_average { @_ > 0 or die 'No numbers sent for averaging.'; my $sum = 0; foreach (@_) { $sum += $_; } return $sum / @_; }

Check for an empty list at the top to avoid a division by zero error.

Log In?

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://994961]
and all is quiet...

How do I use this? | Other CB clients
Other Users?
Others exploiting the Monastery: (5)
As of 2017-07-26 10:04 GMT
Find Nodes?
    Voting Booth?
    I came, I saw, I ...

    Results (388 votes). Check out past polls.