Beefy Boxes and Bandwidth Generously Provided by pair Networks
XP is just a number
 
PerlMonks  

Re: EMPTY OUTPUT FILE GENERATED

by 2teez (Priest)
on Sep 26, 2012 at 09:57 UTC ( #995735=note: print w/ replies, xml ) Need Help??


in reply to EMPTY OUTPUT FILE GENERATED

Hi,

Please help me out to find my flaws

Please consider the following:

  • It's a lot better, to use warnings; and strict; at the top of ones script
  • It's modern ( ha ha... ) and a lot safer to use open 3 arugments
  • Barewords as filehandles might not be too good, you can use lexical variable of your choice.
  • Lastly, you will want to close, your filehandles, as soon as they are opened

Below is the reconstruct of your script.
Please, note I used regex to get what I assumed to be first column of your data used.
Using split or even substr might probabily be better, if OPs data is known. I can only assume data here.
use warnings; use strict; open my $fh, '>', 'outfile3.txt' or die "can't open file: $!"; open my $fh2, '<', 'file1.txt' or die "can't open file: $!"; while ( defined( my $line = <$fh2> ) ) { if ( $line =~ m{^(?<matched>.+?)\s+?.*?$}){ print {$fh} $+{matched}, $/; } } close $fh2 or die "can't close file: $!"; close $fh or die "can't close file: $!";
Hope this helps.

If you tell me, I'll forget.
If you show me, I'll remember.
if you involve me, I'll understand.
--- Author unknown to me


Comment on Re: EMPTY OUTPUT FILE GENERATED
Download Code

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://995735]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others browsing the Monastery: (14)
As of 2015-07-06 17:30 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









    Results (77 votes), past polls