|Keep It Simple, Stupid|
Re^2: Seeking your opinions on proposed patch to File::Utilby martell (Friar)
|on Sep 30, 2012 at 08:39 UTC||Need Help??|
First thanks for your excellent work. I'm using it regularly.
I personally encountered the 'bug' and I worked around it by performing a list without a pattern and then grepping the whole list myself. Will you break my code with changing the behaviour of --pattern? I think not, but I have some testing to do.
Some other thoughts about the above proposal: I see a small issue with the above proposition of --file-pattern and --dir-pattern.
In list dir, you already have the switches --dirs-only and --files-only. This makes the above switches a bit confusing. I suppose the combination of the switches --files-only --dir-pattern will give me all files in the matching directories. But do I get also the files of the root dir where the search was started? Because this directory isn't matched against the --dir-pattern. And I honestly don't known what the default expectation will be.
So, either document the switches really well and watch out for unexpected behaviour like this borderline case above, or keep it simple. And I personally like simple best. So for me, you can change the --pattern behaviour and even leave the out --file-pattern && --dir-pattern. Those switches aren't crucial. Keep focussing on cross OS functionality of your toolbox, because that's the reason why I'm using your module. And if really needed, it is a simple exercise to perform the filtering ourselves.
My humble 2 cents