Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??
package Perl::Critic::Policy::ValuesAndExpressions::UndefinedBehaviour +MaybeQuoteit; our $VERSION = '0.01'; use strict; use warnings; use Readonly; use parent 'Perl::Critic::Policy'; use Perl::Critic::Utils qw{ :severities }; sub supported_parameters { return () } sub default_severity { return $SEVERITY_MEDIUM } sub default_themes { return qw< bugs maintenance > } sub applies_to { return qw/PPI::Statement/ } Readonly::Scalar my $DESC => q{$1 not quoted (value not frozen) undefi +ned behaviour}; Readonly::Scalar my $EXPL => q{Maybe $1 should be quoted ( "$1" ) to p +revent undefined behaviour (to freeze the value)}; sub violates { my ( $self, $elem, undef ) = @_; return if ref($elem) !~ m{^(?:PPI::Statement::Variable|PPI::Statem +ent::Expression|PPI::Statement)$}; my $magic = $elem->find('PPI::Token::Magic'); my $operator = $elem->find('PPI::Token::Operator'); my $word = $elem->find('PPI::Token::Word'); if( $magic ){ my $dollar = 0; for my $mag ( @$magic ){ $dollar++ if $mag->content =~ m/^\$\d+$/; } if( $dollar and ( $word or $operator ) ){ return $self->violation( $DESC, $EXPL, $elem ); } } return; } 1; # End of Perl::Critic::Policy::ValuesAndExpressions::UndefinedBehav +iourMaybeQuoteit

Warns/Criticizes on  Foo( $1 ); or  $1 + Foo();

Why? See $1 not "freezing" in an addition

I tested it with perlcritic -3 foo.pl

Seems to work :)


In reply to Perl::Critic::Policy::ValuesAndExpressions::UndefinedBehaviourMaybeQuoteit / $1 not quoted (value not frozen) undefined behaviour by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • Outside of code tags, you may need to use entities for some characters:
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others having an uproarious good time at the Monastery: (6)
    As of 2014-09-21 19:10 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?

      How do you remember the number of days in each month?











      Results (175 votes), past polls