This is how I would do it. The main changes were:
- Do not declare variables in a wider scope than needed.
- Use lexical filehandles and 3-argument open with or die.
- If you want to output frequencies per file, you have to store them per file. That's why the first key is the filename.
- The line is already in the key, no need to store it again to a value.
- You do not have to initialize the counting hash. Just increment it.
#!/usr/bin/perl
use warnings;
use strict;
my %cnt;
for my $file (glob '*.abc') {
open my $FILE, '<', "$file" or die "$!";
for my $line (grep / FREQ /, <$FILE>) {
$line =~ s/ is begin.*//;
$line =~ s/.* FREQ/FREQ/;
chomp($line);
$cnt{$file}{$line}++;
}
}
for my $file ( keys %cnt) {
for my $line ( keys %{ $cnt{$file} } ) {
print "$file $line $cnt{$file}{$line}\n";
}
}
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Outside of code tags, you may need to use entities for some characters:
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
|
|