Beefy Boxes and Bandwidth Generously Provided by pair Networks
Your skill will accomplish
what the force of many cannot
 
PerlMonks  

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??

Hi all,

digging in the code of a popular web framework (yes, yes, learning by reading) I found an equivalent to the following snippet:

sub readfile { my $filename = shift or return; ... }

When you look at CPAN code you see this kind of idiom often. But with this idiom you declare a string of "0" as bad input. In this case: Why shouldn't I have a file named "0"? Sometimes I get the feeling that simply the look and feel of the code is the reason to do so. Ignoring the //-operator (starting with 5.10) you would have to write the following to allow a string "0":

my $filename = shift; return unless(defined $filename && $filename ne '');
This is really not so fancy like the above
my $filename = shift or return;

So, my question: Do you think the programmers are not aware of the subtle difference? Do you think they know it but they like the fancy code more accepting to declare a valid input as bad? I have a bad feeling seeing problematic idioms cemented by popular code. What do you think?

Sidenote: The //-operator was a step in the right direction, but IMHO an operator like in bash (-n $filename) is missing.

McA


In reply to Wrong idioms by McA

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others rifling through the Monastery: (11)
    As of 2015-07-29 07:45 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?

      The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









      Results (260 votes), past polls