Beefy Boxes and Bandwidth Generously Provided by pair Networks
XP is just a number

Comment on

( #3333=superdoc: print w/replies, xml ) Need Help??

I have two arrays. The first array contains several strings. The second array contains elements, each of which might be a substring of an element in the first array.

Now I want to figure out which of the elements of the first array match the substrings in the 2nd array and do something with the other elements of the 1st array.

My code:

#!/usr/bin/perl use strict; my @array = ("foo {abc123}\n", "bar {def456}\n", "baz {ghi789}\n"); my @array2 = ("foo", "bar", "quux"); foreach my $i (@array) { chomp $i; print "checking $i\n"; if ($i =~ m/@array2/) { print "$i is in array2 - skipping\n"; next; } # Do something with $i now. }

Of course that didn't work

So I then tried adding this before the loop:

my $regex = "("; foreach (@array2) { $regex .= $_ . "|"; } $regex .= ")";
and then changing the if to:
if ($i =~ m/$regex/) {

And that matched every element although it shouldn't have matched the last one (I really am perplexed by this)

So now I'm at my last resort and putting an inner loop which goes through array2 and checks each element

#!/usr/bin/perl use strict; my @array = ("foo {abc123}\n", "bar {def456}\n", "baz {ghi789}\n"); my @array2 = ("foo", "bar", "quux"); OUTTER: foreach my $i (@array) { chomp $i; print "checking $i\n"; foreach my $j (@array2) { if ($i =~ m/$j/) { print "$i is in array2 (matches $j) - skipping\n"; next OUTTER; } } print "$i IS NOT IN ARRAY 2\n"; # Do something with $i now. }

So is this really the only way to do it? I can forsee having a very very very large array2 in the not too distant future. I don't think this code will scale well with that (plus the extra loop to me makes the code hard to read). Anyway just hoping there's a better way.

Thanks in advance

Edit:Thanks to everyone who found the problem with the $regex

In reply to regex with arrays and variables by xorl

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?

    What's my password?
    Create A New User
    and all is quiet...

    How do I use this? | Other CB clients
    Other Users?
    Others contemplating the Monastery: (6)
    As of 2017-12-13 08:03 GMT
    Find Nodes?
      Voting Booth?
      What programming language do you hate the most?

      Results (350 votes). Check out past polls.