Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change
 
PerlMonks  

Comment on

( #3333=superdoc: print w/replies, xml ) Need Help??

Hello Nige,

Thanks for that, it looks useful.

A few minor points:

  • Although your code is, in fact, strict-compliant, it would be better to make this explicit with use strict;
  • Since you’re not using the list returned by map, it would probably be clearer to use a for loop here:
    s/^(0x|#)(.{6})/$2/ for @hexSs;
  • The statement print "</TR>\n</TR>" is probably meant to be print "</TR>\n<TR>" (i.e. ending the last table row and beginning another)
  • When comparing numbers, use > rather than gt (which is for stringwise comparison)
  • Although the comparison is with 4, the logic actually prints 6 cells per row. I think the following is clearer:
    my $cell = 0; for my $hex (@hexSs) { print "<TD BGCOLOR='#$hex'>", "<FONT COLOR='white'>$hex</FONT><BR /><BR />", "<FONT COLOR='black'>$hex</FONT></TD>"; if (++$cell >= 6) { $cell = 0; print "</TR>\n<TR>"; } }

Hope that helps,

Athanasius <°(((><contra mundum Iustus alius egestas vitae, eros Piratica,


In reply to Re: Colour/color sampler by Athanasius
in thread Colour/color sampler by Nige

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and all is quiet...

    How do I use this? | Other CB clients
    Other Users?
    Others imbibing at the Monastery: (6)
    As of 2017-10-22 16:24 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?
      My fridge is mostly full of:

















      Results (273 votes). Check out past polls.

      Notices?