Since he's an new programmer, I would suggest going easy. I'm going to assume no one else he works with knows Perl at all, otherwise, they wouldn't be going to the DBA's (I don't know, but you may be at one of those places that blame everything on the DBA's). I guess the best things to suggest are the most basic things such as modularization of code, declaring variables (and using meaningful variable names), encouraging him to use the full power of the CGI module (by the way, if you really need a performance boost, mod_perl may not hurt either), etc.
Of course, make sure you present it in the proper manner. If you want to do a good job politically, start with the good things in the script. Then, go through the suggestions in a non-threatening manner, suggesting changes rather than starting with "This stinks!"
Hope this helps.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] ||