I sat through a code review a few months ago. It was my first time, and quite the experience. The person's CGI script started just like yours does above. Then, about thirty or so lines in, there was
$filename =~ m/(.*)/gi;
$filename = $1;
open FILE, "$filename";
I was shocked, as this was code written by a "professional." I can count about six errors in those three lines of code.
- Poor taint checking (none really.)
- Not checking if the match succeeds. I guess it doesn't matter if it's just matching dot star.
- Not checking if the open succeeds.
- Should use the three form of open
- The match is stupid. dot-star doesn't care about case insensitivity (/i).
- The match is really stupid. /g is (i think) for trying to match multiple times in a loop. This doesn't do that.
You are quite right, warnings, strict, CGI, and taint are a good start. But you do need to still read the code before you use it. I don't think there is anything to help avoid a good code review.
update: The programmer still works there. I don't, by my own choice.
- all things inbetween.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
| & || & |
| < || < |
| > || > |
| [ || [ |
| ] || ] ||