My first suggestion, would be to dump the "flag" variable, and change the methods so they return true if the test is "ok", then short circut out if any of the tests fail...

for ($candidate = 12345;
     $candidate <= 98765;
     $candidate++) {
       if (check_prime($candidate) &&
           check_digit_3($candidate) &&
           check_digit_2($candidate) &&
           check_digit_5($candidate) &&
           #check_duplicates($candidate) && # problem?
           check_digit_1($candidate)) {
         print "$candidate\n";
       }
}
[download]

...so you don't waste time on tests that don't matter (because you allready know other tests don't work).

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.