Sorry if this is a bit late, FWIW...
1) Most of the replies published (well, those that work :-) truncate strings that are exactly of the desired length, while your original version keeps these intact. Test case:
my $str = trim_length ( 'this sentence is 30 signs long', 30 );
If you use eg BrowserUK's code, this is easy to fix: just change
return $str if length $str < $n;
to:
return $str if length $str <= $n;
2) It might be an idea to strip off trailing whitespace, in order to avoid adding ' ...' to the end of a message that is essentially complete. My own solution, again FWIW, would be
sub trim_length {
my ( $str, $desired_len ) = @_;
$str =~ s/\s+$//; # Strip trailing whitespace
return $str if length $str <= $desired_len;
return sprintf "%.${desired_len}s ...",
substr $str, 0, ( rindex $str, ' ', $desired_len );
}
dave
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
Outside of code tags, you may need to use entities for some characters:
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.
|
|
