If it works and it is readable, I wouldn't be too concerned about a few for loops. That said, I'd probably do two things: use hash slices (see perldata) instead of all of the individual $data{key} = $_->key; statements, and pull the guts of the for ( @info ) loop into a subroutine (since you use it twice). For example (untested):
for ( @info )
{
push( @loop_data, get_info( $_ ) );
}
sub get_info
{
my ( $info ) = @_;
my $sth = $obj->DBI->Replies->sql_count;
$sth->execute( $info->id );
my $info->count = ( $sth->fetchrow_array )[0];
my @keys = qw( author content title id date count );
my %data;
@data{ @keys } = @$info{ @keys };
return \%data;
}
Note: I changed $r to $info->count to clean up the hash slice. Update: Corrected $count to $info->count.
HTH, and congrats on getting it working. That's the first step. :-)
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|