Beefy Boxes and Bandwidth Generously Provided by pair Networks
The stupid question is the question not asked
 
PerlMonks  

Comment on

( #3333=superdoc: print w/ replies, xml ) Need Help??
  • This seems in order: sub fmt_percent { sprintf("...", $_[0] }
  • I would try to do away with most of the file scoped vars (my $tt) etc, by trying to consolidate the logic that drives them into single expressions... I find that reading an expression in one go has more of a mnemonic effect than many variables which are similar in nature. This only works to some extent, though.
  • I like your use of grep in scalar context
  • I don't like your use of print-like-a-function.... You can omit the parens.
  • I'm not sure, but maybe my @files = glob("/var/log/maillog*") is in order
Aside from that, this is good code, readable, well structured, and so forth. I'm assuming it was formatted more structuredly before it was posted ;-)

Ciao!

-nuffin
zz zZ Z Z #!perl

In reply to Re: SpamAssassin / Amavis-new / Clam-AV by nothingmuch
in thread SpamAssassin / Amavis-new / Clam-AV by cajun

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?
    Username:
    Password:

    What's my password?
    Create A New User
    Chatterbox?
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others chilling in the Monastery: (7)
    As of 2015-07-04 06:25 GMT
    Sections?
    Information?
    Find Nodes?
    Leftovers?
      Voting Booth?

      The top three priorities of my open tasks are (in descending order of likelihood to be worked on) ...









      Results (58 votes), past polls