G'day s_gaurav1091
Trying to reduce your steps? Sounds like good old fashioned perl-golf. ;) However, I'll try to give suggestions that make your code more tidy but without loss of readability.
You can reduce your if to testing a single regular expression. The code below uses some more specific variable names, and pushes non-oracle variables onto our output array without alteration.
my @envArray = `rsh sdp1 su - oracle8 -c env `;
my @translated_env; # Rather than '@array'.
foreach (@envArray) {
if ( m{^( ORACLE_SID | ORACLE_HST_SID | ORACLE_HOME | SDP_HOME )=(
+.*)}ix ) {
# Look, an oracle variable!
my ($env_key, $env_value) = ($1, $2); # $env_key rather tha
+n $temp
# Tweak it...
$env_key = lc($env_key);
$env_key =~ tr{_}{.}; # Transliterate _ to
+.
# And put it into our array.
push(@translated_env,"$env_key=$env_value");
}
else {
# Otherwise leave the environment variable unharmed.
push(@translated_env,$_);
}
}
The code can certainly be reduced to a smaller number of steps, but I believe that maintainability is more important than clever tricks. It should be noted that the m{...}x construct allows whitespace (and comments) to be inserted without the meaning of the regexp changing. Also note that the assignment into $env_key and $env_value could be done inside the if condition, but results in a condition that I at least would consider too long.
All the best,
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|