Beefy Boxes and Bandwidth Generously Provided by pair Networks
P is for Practical
 
PerlMonks  

comment on
( [id://3333]=superdoc: print w/replies, xml ) Need Help??
hi my script is ready , it will grab a bunch of logs and filter it with values provided by MSISDN file and sort it to different hashs to sppol out mail files ( i dont implement automails because i want to check first)
there are definatly a lots of thinks i can do better but im quit happy that it works ;D
sugestions of how i can do better are welcome ;D 
#!/usr/bin/perl -w

use strict;
use File::Spec;

my $spec_text = qr/Smt22/;
my $path_tmp = $0; 
(my $volume,my $directories,my $file) = File::Spec->splitpath( $path_t
+mp );
my $path = $volume . $directories;
opendir (DIRREN, $path) || die ;
my @RENDIR = readdir (DIRREN);
close (DIRREN);
my $match_file = "MSISDN.txt";
my @matches=();
# open file and load into array
open(my $match_in, '<', $match_file) or die("open failed: $!"); my @ma
+tches_in = <$match_in>; close($match_in);
foreach my $file (@RENDIR) { if ($file =~ $spec_text){ open(my $fh_in,
+ '<', $file) or die("open failed: $!"); my @lines = <$fh_in>;    clos
+e($fh_in);
foreach my $lines (@lines) {
foreach my $matches_in (@matches_in) {
    my @matche = split(',',$matches_in);
    my $matchtmp = qr/$matche[1].*(Returned error code 52|Returned err
+or code 50|Returned error code 79|Returned error code 22|Returned err
+or code 24)/;
    if($lines =~ qr/$matchtmp/) { push @matches, $lines; }}}}}
undef(@matches_in);
my @newmatch = ();
my @tmplist = ();

#split logfile line into needs and put together everything ;D
foreach my $match (@matches) { chomp $match; @newmatch = split(';',$ma
+tch);    my @tmpnewmatch = split(',',$newmatch[6]);
    #cuts the blanks @ beginning and end of each string element
    $newmatch[5] =~ s/^\s+//; $tmpnewmatch[0] =~ s/^\s+//; push @tmpli
+st, $newmatch[5] . ";" . $tmpnewmatch[0]; }

# removes duplicates and print out MD Del list
my @list= do { my %seen; grep !$seen{$_}++, @tmplist }; undef(@matches
+); undef(@newmatch); undef(@tmplist);
open(INFILE, '<', "MSISDN.txt") or die("open failed: $!");
open(MDDELOUT, '>', "MD_delete_list.txt") or die("open failed: $!");
while (<INFILE>) { my @mdmsisdn = split(',',$_); $mdmsisdn[1] =~ s/^\s
++//; foreach my $mddel (@list) { my @newmddel = split(';',$mddel); 
    if ($newmddel[0]==$mdmsisdn[1]) { print MDDELOUT "$mdmsisdn[0] ; $
+mddel \n"; }}} close(INFILE); close(MDDELOUT);

#put the list into an array to easyly search for msisdn, will pe put i
+n different hashes one for each errorcode
my %adv22=(); my %adv24=(); my %adv50=(); my %adv52=(); my %adv79=();
foreach my $list (@list) { (my $msisdn,my $adverror)= split(';',$list)
+; 
    if ($adverror eq "ADV: Returned error code 22") { $adv22{$msisdn}=
+$adverror; }
    elsif ($adverror eq "ADV: Returned error code 24") { $adv24{$msisd
+n}=$adverror; }
    elsif ($adverror eq "ADV: Returned error code 50") { $adv50{$msisd
+n}=$adverror; }
    elsif ($adverror eq "ADV: Returned error code 52") { $adv52{$msisd
+n}=$adverror; }
    elsif ($adverror eq "ADV: Returned error code 79") { $adv79{$msisd
+n}=$adverror; }
    else { print "no ADV Errors ;D" }
} undef(@list);

#open errorfiles and check if msisdn is already known then sorting to 
+existing or not
open(my $exmsisdn79, '<', "adv79.txt") or die("open failed: $!"); my @
+exerrors79 = <$exmsisdn79>; close($exmsisdn79);
my @tmpnew79=(); my @tmpold79=();
foreach my $adv79key (keys %adv79) {
   if ( grep { $adv79key == $_ } @exerrors79 ) { print "$adv79key is a
+n old error\n"; push @tmpold79, $adv79key . "\n"; } 
   else { print "$adv79key is a new error\n"; push @tmpnew79, $adv79ke
+y . "\n"; }}

open(my $exmsisdn52, '<', "adv52.txt") or die("open failed: $!"); my @
+exerrors52 = <$exmsisdn52>; close($exmsisdn52);
my @tmpnew52=(); my @tmpold52=();
foreach my $adv52key (keys %adv52) {
   if ( grep { $adv52key == $_ } @exerrors52 ) { print "$adv52key is a
+n old error\n"; push @tmpold52, $adv52key . "\n"; } 
   else { print "$adv52key is a new error\n"; push @tmpnew52, $adv52ke
+y . "\n"; }}

open(my $exmsisdn50, '<', "adv50.txt") or die("open failed: $!"); my @
+exerrors50 = <$exmsisdn50>; close($exmsisdn50);
my @tmpnew50=(); my @tmpold50=();
foreach my $adv50key (keys %adv50) {
   if ( grep { $adv50key == $_ } @exerrors50 ) { print "$adv50key is a
+n old error\n"; push @tmpold50, $adv50key . "\n"; } 
   else { print "$adv50key is a new error\n"; push @tmpnew50, $adv50ke
+y . "\n"; }}

open(my $exmsisdn24, '<', "adv24.txt") or die("open failed: $!"); my @
+exerrors24 = <$exmsisdn24>; close($exmsisdn24);
my @tmpnew24=(); my @tmpold24=();
foreach my $adv24key (keys %adv24) {
   if ( grep { $adv24key == $_ } @exerrors24 ) { print "$adv24key is a
+n old error\n"; push @tmpold24, $adv24key . "\n"; } 
   else { print "$adv24key is a new error\n"; push @tmpnew24, $adv24ke
+y . "\n"; }}

open(my $exmsisdn22, '<', "adv22.txt") or die("open failed: $!"); my @
+exerrors22 = <$exmsisdn22>; close($exmsisdn22);
my @tmpnew22=(); my @tmpold22=();
foreach my $adv22key (keys %adv22) {
   if ( grep { $adv22key == $_ } @exerrors22 ) { print "$adv22key is a
+n old error\n"; push @tmpold22, $adv22key . "\n"; } 
   else { print "$adv22key is a new error\n"; push @tmpnew22, $adv22ke
+y . "\n"; }}

#put new errors in arry to existing errors dupe check it and write bac
+k to file
foreach my $tmpexout79 (@tmpnew79) { push @exerrors79,$tmpexout79; } m
+y @newexout79= do { my %seen79; grep !$seen79{$_}++, @exerrors79 }; u
+ndef(@exerrors79);
foreach my $tmpexout52 (@tmpnew52) { push @exerrors52,$tmpexout52; } m
+y @newexout52= do { my %seen52; grep !$seen52{$_}++, @exerrors52 }; u
+ndef(@exerrors52);
foreach my $tmpexout50 (@tmpnew50) { push @exerrors50,$tmpexout50; } m
+y @newexout50= do { my %seen50; grep !$seen50{$_}++, @exerrors50 }; u
+ndef(@exerrors50);
foreach my $tmpexout24 (@tmpnew24) { push @exerrors24,$tmpexout24; } m
+y @newexout24= do { my %seen24; grep !$seen24{$_}++, @exerrors24 }; u
+ndef(@exerrors24);
foreach my $tmpexout22 (@tmpnew22) { push @exerrors22,$tmpexout22; } m
+y @newexout22= do { my %seen22; grep !$seen22{$_}++, @exerrors22 }; u
+ndef(@exerrors22);

open(OUT22, '>', "adv22.txt") or die("open failed: $!"); foreach my $n
+ewout22 (@newexout22) { print OUT22 $newout22; } undef(@newexout22);
open(OUT24, '>', "adv24.txt") or die("open failed: $!"); foreach my $n
+ewout24 (@newexout24) { print OUT24 $newout24; } undef(@newexout24);
open(OUT50, '>', "adv50.txt") or die("open failed: $!"); foreach my $n
+ewout50 (@newexout50) { print OUT50 $newout50; } undef(@newexout50);
open(OUT52, '>', "adv52.txt") or die("open failed: $!"); foreach my $n
+ewout52 (@newexout52) { print OUT52 $newout52; } undef(@newexout52);
open(OUT79, '>', "adv79.txt") or die("open failed: $!"); foreach my $n
+ewout79 (@newexout79) { print OUT79 $newout79; } undef(@newexout79);

#printing out final records to mail ;D
open(OUTMAIL22, '>', "adv22_mail.txt") or die("open failed: $!"); prin
+t OUTMAIL22 "Here goes the text needed befor MSISDN \n NEW MSISDNs\n\
+n"; foreach my $mail22 (@tmpnew22) { print OUTMAIL22 "$mail22"; } pri
+nt OUTMAIL22 "\n EXISTING MSISDNs\n"; foreach my $mailold22 (@tmpold2
+2) { print OUTMAIL22 "$mailold22"; } close(OUTMAIL22); undef(@tmpold2
+2); undef(@tmpnew22);
open(OUTMAIL24, '>', "adv24_mail.txt") or die("open failed: $!"); prin
+t OUTMAIL24 "Here goes the text needed befor MSISDN \n NEW MSISDNs\n\
+n"; foreach my $mail24 (@tmpnew24) { print OUTMAIL24 "$mail24"; } pri
+nt OUTMAIL24 "\n EXISTING MSISDNs\n"; foreach my $mailold24 (@tmpold2
+4) { print OUTMAIL24 "$mailold24"; } close(OUTMAIL24); undef(@tmpold2
+4); undef(@tmpnew24);
open(OUTMAIL50, '>', "adv50_mail.txt") or die("open failed: $!"); prin
+t OUTMAIL50 "Here goes the text needed befor MSISDN \n NEW MSISDNs\n\
+n"; foreach my $mail50 (@tmpnew50) { print OUTMAIL50 "$mail50"; } pri
+nt OUTMAIL50 "\n EXISTING MSISDNs\n"; foreach my $mailold50 (@tmpold5
+0) { print OUTMAIL50 "$mailold50"; } close(OUTMAIL50); undef(@tmpold5
+0); undef(@tmpnew50);
open(OUTMAIL52, '>', "adv52_mail.txt") or die("open failed: $!"); prin
+t OUTMAIL52 "Here goes the text needed befor MSISDN \n NEW MSISDNs\n\
+n"; foreach my $mail52 (@tmpnew52) { print OUTMAIL52 "$mail52"; } pri
+nt OUTMAIL52 "\n EXISTING MSISDNs\n"; foreach my $mailold52 (@tmpold5
+2) { print OUTMAIL52 "$mailold52"; } close(OUTMAIL52); undef(@tmpold5
+2); undef(@tmpnew52);
open(OUTMAIL79, '>', "adv79_mail.txt") or die("open failed: $!"); prin
+t OUTMAIL79 "Here goes the text needed befor MSISDN \n NEW MSISDNs\n\
+n"; foreach my $mail79 (@tmpnew79) { print OUTMAIL79 "$mail79"; } pri
+nt OUTMAIL79 "\n EXISTING MSISDNs\n"; foreach my $mailold79 (@tmpold7
+9) { print OUTMAIL79 "$mailold79"; } close(OUTMAIL79); undef(@tmpold7
+9); undef(@tmpnew79);

[download]

In reply to Re: problem with foreach statement by ultibuzz
in thread problem with foreach statement by ultibuzz

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":


  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?

www.com | www.net | www.org
Chatterbox?
and the web crawler heard nothing...

How do I use this? • Last hour • Other CB clients
Other Users?
Others having an uproarious good time at the Monastery: (6)
As of 2024-04-19 02:32 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found